Skip to content

CSS: Fix parsing of @keyframes rules#8053

Merged
matthiasblaesing merged 1 commit intoapache:masterfrom
matthiasblaesing:keyframes
Dec 24, 2024
Merged

CSS: Fix parsing of @keyframes rules#8053
matthiasblaesing merged 1 commit intoapache:masterfrom
matthiasblaesing:keyframes

Conversation

@matthiasblaesing
Copy link
Contributor

Before 23ed111 "CSS: Improve handling of generic-at-rules (for example used by tailwind)" the CSS parser returned the body of generic @-rules as a plain list of tokens. That changed and the @Keyframes rule needs to be special cased. There was already a special case for the @-webkit-keyframes variant, which is identical to the final variant and differs only in the introducing rule name.

Closes: #8052

@matthiasblaesing matthiasblaesing added CSS [ci] enable web job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Dec 14, 2024
@matthiasblaesing matthiasblaesing added this to the NB25 milestone Dec 14, 2024
Before 23ed111 "CSS: Improve handling
of generic-at-rules (for example used by tailwind)" the CSS parser
returned the body of generic @-rules as a plain list of tokens. That
changed and the @Keyframes rule needs to be special cased. There was
already a special case for the @-webkit-keyframes variant, which is
identical to the final variant and differs only in the introducing
rule name.

The vendored variants @-moz-keyframes and @-o-keyframes are also
supported.

Closes: apache#8052
@matthiasblaesing
Copy link
Contributor Author

I intent to merge this before christmas, so if you want me to wait, speak now please.

@matthiasblaesing matthiasblaesing merged commit e60cf75 into apache:master Dec 24, 2024
31 checks passed
@matthiasblaesing matthiasblaesing deleted the keyframes branch January 9, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) CSS [ci] enable web job

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid CSS parcing error in @keyframes rule

1 participant

Comments